etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Fix the auto-compaction-retention logging in the startup

Open akin-tekeoglu opened this issue 1 year ago • 8 comments

Fixes #17822

It seemed to me that auto-compaction-interval was useless so I nuked it

akin-tekeoglu avatar May 12 '24 17:05 akin-tekeoglu

Hi @akin-tekeoglu. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 12 '24 17:05 k8s-ci-robot

/ok-to-test

jmhbnz avatar May 13 '24 03:05 jmhbnz

I see your name in the OWNERS file @fuweid. Can you take a look?

akin-tekeoglu avatar May 14 '24 09:05 akin-tekeoglu

/retest-required

akin-tekeoglu avatar May 15 '24 19:05 akin-tekeoglu

/retest

jmhbnz avatar May 24 '24 08:05 jmhbnz

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 23 '24 09:08 k8s-ci-robot