etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Bump go 1.21.10 and 1.22.3

Open ahrtr opened this issue 9 months ago • 15 comments

What would you like to be added?

Both 1.21.10 and 1.22.3 include security fixes

Why is this needed?

fix CVE

ahrtr avatar May 07 '24 16:05 ahrtr

Completion tracking below:

  • [x] main: go v1.22.3 - #17975
  • [x] release-3.5: go v1.21.10 - #17980
  • [x] release-3.4: go v1.21.10 - #17981
  • [x] CHANGELOG - #18019
  • [x] etcd-io/bbolt main: go v1.22.3 - etcd-io/bbolt#753
  • [x] etcd-io/bbolt release-1.3: v1.21.10 - etcd-io/bbolt#754
  • [x] etcd-io/raft main: go v1.22.3 - etcd-io/raft#199

Refer to previous PRs as a reference, i.e., https://github.com/etcd-io/etcd/issues/17269

ivanvc avatar May 07 '24 20:05 ivanvc

@ahrtr, do we want to update bbolt and raft? Based on recent conversations I'm unsure if that's the intention.

ivanvc avatar May 07 '24 20:05 ivanvc

@ahrtr could you assign this issue to me ?

lavishpal avatar May 07 '24 21:05 lavishpal

/assign @lavishpal

ivanvc avatar May 07 '24 23:05 ivanvc

@ahrtr, do we want to update bbolt and raft? Based on recent conversations I'm unsure if that's the intention.

I think the answer is YES. We follow the same rule as documented in dependency_management.md#golang-versions for all repos, and also https://github.com/etcd-io/etcd/pull/17876

ahrtr avatar May 08 '24 05:05 ahrtr

Can we submit the PRs of bumping golang version for etcd (including main, release-3.5 and release-3.4) this week? Otherwise we will keep seeing failed workflow checks.

We also need to release new patches for 3.5 and 3.4 soon.

ahrtr avatar May 09 '24 08:05 ahrtr

Can we submit the PRs of bumping golang version for etcd (including main, release-3.5 and release-3.4) this week? Otherwise we will keep seeing failed workflow checks.

We also need to release new patches for 3.5 and 3.4 soon.

It would be nice to have it done ASAP since this is blocking https://github.com/etcd-io/etcd/pull/17973 as the CI will not pass (and we would not like this to spillover to next week).

@ahrtr Maybe I can take over the etcd main branch update so I can proceed with the dependency update normally, while in the meantime @lavishpal can take his/her time working on the rest of the branches? :)

henrybear327 avatar May 09 '24 10:05 henrybear327

Ping @lavishpal. Would you work on this this week? Otherwise, we may need to reassign to some collaborator who can help with it, as it is making it fail our CI jobs. Thanks.

ivanvc avatar May 09 '24 10:05 ivanvc

I will complete this within 2 days .

lavishpal avatar May 09 '24 10:05 lavishpal

Hey @lavishpal - Do you have capacity to complete the remainder of the pull requests listed in the completion tracker above https://github.com/etcd-io/etcd/issues/17964#issuecomment-2099276868?

jmhbnz avatar May 10 '24 11:05 jmhbnz

Hey @lavishpal - Do you have capacity to complete the remainder of the pull requests listed in the completion tracker above https://github.com/etcd-io/etcd/issues/17964#issuecomment-2099276868?

Yeah i will complete it by tomorrow.

lavishpal avatar May 10 '24 12:05 lavishpal

Wow, that was very quick. Thanks for the PRs, @lavishpal. Please update the ' CHANGELOG ' after closing #17980 and #17981.

Thanks again.

ivanvc avatar May 10 '24 16:05 ivanvc

Also, as reference 1.21.10/1.22.3 address CVE: CVE-2024-24787.

ivanvc avatar May 10 '24 16:05 ivanvc

@lavishpal, do you have the capacity to update the CHANGELOGs? As a reference, this is the PR when we updated them to 1.20.13: https://github.com/etcd-io/etcd/pull/17309

Thanks

ivanvc avatar May 12 '24 18:05 ivanvc

@lavishpal, do you have the capacity to update the CHANGELOGs? As a reference, this is the PR when we updated them to 1.20.13: #17309

Thanks

@ivanvc Sure i will finish it by tomorrow.

lavishpal avatar May 12 '24 18:05 lavishpal

I think we are ready to release new patches for both 3.4 and 3.5. @jmhbnz @spzala

ahrtr avatar May 14 '24 12:05 ahrtr

I think we are ready to release new patches for both 3.4 and 3.5. @jmhbnz @spzala

Agree. I've opened the planning issues:

  • https://github.com/etcd-io/etcd/issues/18013
  • https://github.com/etcd-io/etcd/issues/18014

I am happy to be release lead for v3.5.14, @spzala do you have availability to lead v3.4.33 release?

jmhbnz avatar May 15 '24 08:05 jmhbnz

With all the tasks completed, we can close this issue now. Thanks, @lavishpal, for helping with this.

ivanvc avatar May 17 '24 04:05 ivanvc