etcd Backport failpoints to old releases

What would you like to be added?

Backport all the failpoint comments from main branch to release-3.4 and release-3.5. For example compactBeforeSetFinishedCompact from https://github.com/etcd-io/etcd/issues/17780

TODO: Find all comments like // gofail: var compactBeforeSetFinishedCompact struct{} and backport them to old releases.

Why is this needed?

This will allow running https://github.com/etcd-io/etcd/pull/17815 on old releases and allow robustness test to use them.

Apr 17 '24 15:04 serathius

Hello @serathius , can you assign this issue to me?

Sep 12 '24 04:09 ciphx

/assign @ciphx

Sep 12 '24 07:09 serathius

ping @ciphx any progress?

Oct 26 '24 09:10 serathius

Unassigning due to lack of progress.

Feb 14 '25 11:02 serathius

/assign @gangli113

Feb 20 '25 19:02 gangli113

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

May 31 '25 00:05 github-actions[bot]

https://github.com/etcd-io/etcd/pull/19525 backported changes to release-3.5, we still need to backport to release-3.4

/cc @nwnt @joshjms @henrybear327

Jun 07 '25 07:06 serathius

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

Aug 08 '25 00:08 github-actions[bot]

Simple issue with example https://github.com/etcd-io/etcd/pull/19525 for release-3.5

We need to backport the failpoints one more time to release-3.4

To decide which failpoints to backport best to compare for failpoints available on release-3.4 vs main branch.

Aug 08 '25 06:08 serathius

Hi @serathius, I would like to take this up and perform the backport for release-3.4. Will create a PR and share it here.

Aug 14 '25 13:08 sampathbalivada

With https://github.com/etcd-io/etcd/pull/20489 this is done.

Thanks for help @sampathbalivada.

Aug 14 '25 17:08 serathius