etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Supporting setting LocalAddr in peer communication

Open highpon opened this issue 2 years ago • 4 comments

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This PR addresses https://github.com/etcd-io/etcd/issues/17068

highpon avatar Dec 09 '23 12:12 highpon

Hi @highpon. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Dec 09 '23 12:12 k8s-ci-robot

/ok-to-test

jmhbnz avatar Dec 09 '23 18:12 jmhbnz

@jmhbnz Thanks for your help! I signed my commit.

highpon avatar Dec 09 '23 19:12 highpon

@highpon any update on this?

ahrtr avatar Feb 14 '24 10:02 ahrtr

@highpon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-amd64 b978683775c2f0410e1ef9dc5fa1868f16ee42fc link true /test pull-etcd-unit-test-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jun 05 '24 23:06 k8s-ci-robot

I think we can close this pull request, as #17661 superseded this pull request, and is already merged.

ivanvc avatar Jun 06 '24 00:06 ivanvc