Issue 9533

[Hendrik-H]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[Hendrik-H]

The TestEmbedEtcdClusterStartPartialInsecure currently fails. In works if e.Server.Stop() is added before e.Close(). But I don't think that should be required.

[ahrtr]

Please signoff each commit, you need to add Signed-off-by: xxx for each commit. Pls refer to the second commit how I added it.

ALso please read https://github.com/etcd-io/etcd/pull/16758/checks?check_run_id=17682631459

[Hendrik-H]

added the "Signed-off-by" parts

[Hendrik-H]

fixed an issue with a test case

[Hendrik-H]

Not sure why some tests are failing. I can not reproduce that locally.

[ahrtr]

Please try the same command as https://github.com/etcd-io/etcd/blob/aea6f0b4c2fcdd08dd4d4d82f46570cb246fd80d/.github/workflows/tests.yaml#L47-L50

[Hendrik-H]

The race condition is resolved and I don't get any errors locally anymore. So I'm unable to reproduce the embed_test.go:236: etcdserver: unhealthy cluster issue from https://github.com/etcd-io/etcd/actions/runs/6532844996/job/17736984772?pr=16758. Not sure how https://github.com/etcd-io/etcd/actions/runs/6532844983/job/17736983879?pr=16758 is connected to my change. Are there other commands I should run locally?

[Hendrik-H]

I'm finally able to reproduce the unhealthy cluster issue. Working on a fix ...

[Hendrik-H]

All tests listed at https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#implement-your-change pass for me locally now. @ahrtr could you please rerun the checks?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.