etcd
etcd copied to clipboard
etcd-io
etcdctl: add etcdctl snapshot pipe command
To improve the security of etcdctl. Added the ability to write snapshots to stdout without writing data to disk. Useful for read-only file systems.
Solves https://github.com/etcd-io/etcd/issues/16242
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This way, we could reuse most of the logic while providing flexibility in saving the snapshot to different destinations, such as an actual file or
os.Stdout.
I agree with James. Much of the logic can be refactored by passing a file writer into SaveWithVersion.
@Ais8Ooz8 can you followup on this? Thanks!
@Ais8Ooz8 can you fix the fmt error? It is a nitty one about an empty line. Thanks!
Discussed during sig-etcd triage - this is looking good, @ahrtr could you please take a look for final review?
QQ, isn't the UNIX convention to use - as a file name to mean writing to pipe? At least tar does it.
So that would be etcdctl snapshot safe -.
High level, I don't think we need a separate command, it can be just a flag.
@ahrtr Since most encryption and compression utilities work with standard streams, and s3 utilities have subcommands such as aws s3 cp - or mc pipe, it seems like a real use case because it can be used in a single pipeline.
@serathius I think tar uses - along as --files-from=- for stdin and --to-stdout for stdout. In general, I agree that we can use a flag instead of a subcommand. Let's discuss which solution would be the most elegant.
Since @serathius has a comment on adding a flag instead of a new command, so leave to @serathius to take a second look.
Either a flag or a new command works for me. A new command is slight clearer, but not a big deal in this case.