etcd
etcd copied to clipboard
Move grpc-proxy to separate repo
What would you like to be added?
Extract grpc-proxy from etcd and move it to separate project.
Why is this needed?
Complexity of testing grpcproxy greatly reduced our ability to reduce flakiness of etcd tests.
Hi @serathius , Could you provide more detail for it? where can begin?
Try to disassemble this issue
- [ ] Migrate etcd-grpc-proxy to a separate repo, and migrate the logic related to etcd-grpc-proxy startup, so it needs ~~you~~ maintainer to create a repo first, I have created such a repo, check https://github.com/liangyuanpeng/etcd-grpc-proxy
- [ ] Migrate test scripts from etcd repo, including integration tests and e2e tests. (https://github.com/etcd-io/etcd/blob/main/.github/workflows/grpcproxy.yaml)
- [ ] Delete etcd-grpc-proxy related code from etcd repo.
Two questions :
- Does etcd still need to support the etcd grpx-proxy command, it's mean the built-in startup etcd-grpc-proxy with etcd.
- What is the release process of etcd-grpc-proxy? Need to follow etcd version?
Remind me if i missed something,Thanks.
/cc @serathius
@liangyuanpeng I think you're right. If we decide to separate the proxy to another repo, it needs maintainer to init project at first :)
It seems etcd depends on grpc-proxy from the v3client level.
How exactly grpc-proxy should be separated? Only from the etcd binary (etcdmain) or should absolutely all code from server/proxy/grpcproxy be (re)moved?