etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Published 20 hours ago • verified publisher icon etcd-io

Plans for v3.5.5 release

Open serathius opened this issue 2 years ago • 3 comments

Same as previous v3.5 releases. Let's agree what work should be included in release and track the work. The list presented below will be evolving as community decides to cut/include fixes.

Issues/PRs that should be included for v3.5.5:

  • [ ] https://github.com/etcd-io/etcd/issues/14110
  • [ ] https://github.com/etcd-io/etcd/issues/14039
    • [ ] https://github.com/etcd-io/etcd/pull/14282
  • [x] https://github.com/etcd-io/etcd/issues/14114
    • [x] https://github.com/etcd-io/etcd/pull/14127
  • [x] https://github.com/etcd-io/etcd/pull/12992
    • [x] https://github.com/etcd-io/etcd/pull/14132
  • [x] https://github.com/etcd-io/etcd/pull/14087
  • [x] https://github.com/etcd-io/etcd/issues/14077
    • [x] https://github.com/etcd-io/etcd/pull/14219
  • [x] https://github.com/etcd-io/etcd/pull/14182
    • [x] https://github.com/etcd-io/etcd/pull/14187

Issues reported for v3.5 that still require triage. Would appreciate if someone could take a look to make sure that there is no critical bug hiding within them:

  • https://github.com/etcd-io/etcd/issues/14083
  • https://github.com/etcd-io/etcd/issues/14072
  • https://github.com/etcd-io/etcd/issues/14071
  • https://github.com/etcd-io/etcd/issues/14070
  • https://github.com/etcd-io/etcd/issues/14019
  • https://github.com/etcd-io/etcd/issues/14009
  • https://github.com/etcd-io/etcd/issues/13990
  • https://github.com/etcd-io/etcd/issues/13975
  • https://github.com/etcd-io/etcd/issues/13961
  • https://github.com/etcd-io/etcd/issues/13883
  • https://github.com/etcd-io/etcd/issues/13879

Issues/PRs not required for v3.5.5:

  • https://github.com/etcd-io/etcd/issues/14048
  • https://github.com/etcd-io/etcd/pull/14111

Please feel free to suggest new additional backports/issues worth investigating so we can discuss if they should be included. cc @ptabor @ahrtr @spzala

serathius avatar Jun 21 '22 11:06 serathius

We may also need 14081, because there are some issues related to it. There is no update for the PR for more than 2 weeks. Just pinged the author of the PR, I will try to get it resolved if there is no update or progress this week.

ahrtr avatar Jun 22 '22 05:06 ahrtr

We should include this in the v3.5.5 - https://github.com/etcd-io/etcd/pull/14187

spzala avatar Jul 06 '22 16:07 spzala

Removed https://github.com/etcd-io/etcd/issues/14140 and https://github.com/etcd-io/etcd/issues/14143 from scope as they were reproduced on v3.4, meaning that they are not net new in v3.5. They should still be prioritized, but work can be separate from v3.5 release.

serathius avatar Jul 12 '22 09:07 serathius

We are keenly interested in the open telemetry fix recently merged to the 3.5 release branch: https://github.com/etcd-io/etcd/pull/14312. Is there an ETA for 3.5.5 yet?

zmt avatar Aug 12 '22 23:08 zmt

https://github.com/etcd-io/etcd/issues/14355 - this should be fixed before going for 3.5.5 @serathius @spzala @ahrtr

vivekpatani avatar Aug 17 '22 18:08 vivekpatani

Thanks @vivekpatani . Yes, the fix should be included in 3.5.5, and it should be a minor fix. Refer to https://github.com/etcd-io/etcd/issues/14355#issuecomment-1218493754 and https://github.com/etcd-io/etcd/issues/14355#issuecomment-1218500110

The good news the bug isn't included in any published 3.5 release yet. The bad news it's already included in 3.4.20. So we need to backport the fix to 3.4 as well. Since we have simple workaround (see the links above), so it isn't a critical one.

ahrtr avatar Aug 17 '22 21:08 ahrtr

With fix for https://github.com/etcd-io/etcd/issues/14370 merged in release-3.5 let's resume work on this.

serathius avatar Sep 07 '22 14:09 serathius

@ahrtr @serathius any chance of https://github.com/etcd-io/etcd/issues/14001 for 3.5.5?

dims avatar Sep 07 '22 14:09 dims

Sure

serathius avatar Sep 07 '22 14:09 serathius

Looks like we are ready to release v3.5.5? @ahrtr @spzala @ptabor is there important anything I missed?

serathius avatar Sep 09 '22 09:09 serathius

Looks like we are ready to release v3.5.5? @ahrtr @spzala @ptabor is there important anything I missed?

The only concern is that we need more test this time, because there is a new feature . I suggest to run some sanity test against K8s 1.23/24.

In the meanwhile, I will try to qualify the existing functional test, so that we can also qualify 3.5.6 using the functional test next time.

ahrtr avatar Sep 11 '22 04:09 ahrtr

I am thinking probably we should use Kubernetes's pipeline to verify etcd as well before releasing each version.

ahrtr avatar Sep 14 '22 23:09 ahrtr

I worked with SIG Scalability to test v3.4.21 on 5k kubernetes cluster. Will do the same for v3.5.5. before the release.

serathius avatar Sep 15 '22 07:09 serathius

I worked with SIG Scalability to test v3.4.21 on 5k kubernetes cluster. Will do the same for v3.5.5. before the release.

Is it possible to make this as a regular process? It isn't necessary to be the Scalability test, normal Kubernetes pipeline might be OK usually.

ahrtr avatar Sep 15 '22 07:09 ahrtr

I worked with SIG Scalability to test v3.4.21 on 5k kubernetes cluster. Will do the same for v3.5.5. before the release.

Is it possible to make this as a regular process? It isn't necessary to be the Scalability test, normal Kubernetes pipeline might be OK usually.

I maintain etcd version in Kubernetes so I test all the releases. Kubernetes runs 100 node tests on all changes and 5k nodes once a week (I think). Running 5k is not a problem.

serathius avatar Sep 15 '22 07:09 serathius

Release was done.

serathius avatar Sep 22 '22 08:09 serathius