bbolt icon indicating copy to clipboard operation
bbolt copied to clipboard

chore: align golangci-lint with etcd

Open mmorel-35 opened this issue 10 months ago • 2 comments

Description

Align linter list with etcd. It disables the not compliant linters or rules and integrates the fix that could be done with golangci-lint --fix.

The fix of the disabled rules and linters will come in later PR

mmorel-35 avatar Mar 06 '25 19:03 mmorel-35

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Mar 06 '25 19:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorel-35 Once this PR has been reviewed and has the lgtm label, please assign ptabor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 06 '25 19:03 k8s-ci-robot

I know these are mechanical changes, but given the considerable size of this pull request, I suggest incrementally enabling individual linter rules, while removing merging friction and making reviewing the pull requests easier.

ivanvc avatar Apr 26 '25 05:04 ivanvc

Alright, I updated the PR description and the code to reflect this decision.

mmorel-35 avatar Apr 26 '25 07:04 mmorel-35

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 09 '25 07:05 k8s-ci-robot