bbolt icon indicating copy to clipboard operation
bbolt copied to clipboard
verified publisher icon etcd-io

chore: use go-version-file to read go-version from go.mod

Open mmorel-35 opened this issue 11 months ago • 4 comments

Description

go-version can be read directly from .go-version or go.mod files using go-version-file in setup-go.

This PR uses .go-version to setup-go and allows the removal 'goversion' steps

mmorel-35 avatar Feb 20 '25 06:02 mmorel-35

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Feb 20 '25 06:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc, mmorel-35 Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 20 '25 07:02 k8s-ci-robot

By the way, I just checked, and our gofail and raft repositories have the same way of defining the go version. I believe it comes from the original workflows from the etcd repository. Feel free to update those as well :)

ivanvc avatar Feb 20 '25 08:02 ivanvc

OK ! I will.

mmorel-35 avatar Feb 20 '25 09:02 mmorel-35