bbolt icon indicating copy to clipboard operation
bbolt copied to clipboard
verified publisher icon etcd-io

Decompose the interface

Open tjungblu opened this issue 1 year ago • 4 comments

trying to decouple the interface a bit further, inversing the interface injection again.

/hold

drafting for now, happy to discuss/split the different pieces out

tjungblu avatar Jul 25 '24 07:07 tjungblu

Second commit is breaking the serialization out of the freelist interface, copyall becomes an implementation detail of it and the txchecker now uses a simplified listing function instead.

tjungblu avatar Jul 25 '24 13:07 tjungblu

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-test-4-cpu-arm64 2f5d5840bc431c6c5d50e32da18cc56b545c1703 link true /test pull-bbolt-test-4-cpu-arm64
pull-bbolt-test-4-cpu-race-arm64 2f5d5840bc431c6c5d50e32da18cc56b545c1703 link true /test pull-bbolt-test-4-cpu-race-arm64
pull-bbolt-test-2-cpu-arm64 2f5d5840bc431c6c5d50e32da18cc56b545c1703 link true /test pull-bbolt-test-2-cpu-arm64
pull-bbolt-robustness-arm64 2f5d5840bc431c6c5d50e32da18cc56b545c1703 link true /test pull-bbolt-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Oct 24 '24 21:10 k8s-ci-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Feb 11 '25 17:02 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjungblu Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 03 '25 08:06 k8s-ci-robot