bbolt icon indicating copy to clipboard operation
bbolt copied to clipboard

[release-1.3] chore(CI): add golangci linter rules

Open Elbehery opened this issue 4 months ago • 7 comments

backport of https://github.com/etcd-io/bbolt/pull/993

cc @ahrtr @ivanvc

repalces https://github.com/etcd-io/bbolt/pull/995

Elbehery avatar Aug 21 '25 17:08 Elbehery

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 21 '25 17:08 k8s-ci-robot

@Elbehery, can you update golangci-lint to use version v2.4.0? And let's see if the Windows error persists.

ivanvc avatar Aug 21 '25 22:08 ivanvc

@Elbehery, can you update golangci-lint to use version v2.4.0? And let's see if the Windows error persists.

i think we need to install v2.4.0 in a step before using it

lets see

Elbehery avatar Aug 21 '25 22:08 Elbehery

 golangci-lint run ./...
0 issues.

Elbehery avatar Aug 22 '25 00:08 Elbehery

 golangci-lint run ./...
0 issues.
golangci-lint version                                                        
golangci-lint has version 2.4.0 built with go1.25.0 from 43d03392 on 2025-08-13T23:36:29Z

Elbehery avatar Aug 22 '25 00:08 Elbehery

@ivanvc gh does not use v2.4.0 yet :/

Elbehery avatar Aug 22 '25 00:08 Elbehery

Ah, 2.4.0 uses Go 1.25. We need a previous version (2.3.1). But Windows is still failing. I'll try to set up a Windows machine to replicate this locally.

ivanvc avatar Aug 22 '25 03:08 ivanvc