Eugene Tolmachev comments

Results 112 comments of


                                            Eugene Tolmachev

No UI refresh when travel debug / replay is enabled.

I just tried the debugger on our [ToDo sample](https://github.com/elmish/sample-react-todomvc) and it works as expected. Looking at the template code I think `|> Program.withReactBatched` and `|> Program.withDebugger` are in reverse order....

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

Need to figure out where exactly in React lifecycle we can plug this in and go from there: by the time `lazy` gets access to the view it's wrapping we're...

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

The whole point of this function is to skip recreating the children, so even if something else is easier I don't want to change that specific aspect.

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

I think there are 2 stages that lazy needs to be aware of and handle differently: - child view is created in VDOM, but not rendered into DOM yet -...

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

> * doesn't work when `key` is missing on child Don't think it needs to (or even could, in any meaningful way) - functionally nothing should depend on it being...

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

@theimowski I like where this is heading! ~Since our `equals` works on the model, I think it would be fine to use `GetHashCode()` of the model as well. We should...

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

Hmm, I'd never write it like that, I always apply lazy in the outside/parent view which seems to offer consistent hash.

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

Frankly I don't understand why it gives consistent hash (even if you partially apply it OR across recompiles, according to the REPL), but your way constructs a new function, mine...

See if we can move `key` prop from a view we're wrapping into the element produced by `lazyView`

Hmm, that doesn't make sense, even in CLR world that should have been stable, unless that cast is doing something strange. Anyway, I'm convinced now that the model hash is...

See if we can get rid of explicit `dispatch` in the views

There's a recent question in gitter where someone thought it would be a good idea to capture the dispatch reference and pass it via a message over to some other...