ng-table icon indicating copy to clipboard operation
ng-table copied to clipboard

Table not rendering in IE8

Open abhishekhingu opened this issue 10 years ago • 8 comments

Hi

Table based grid (ngTable) not working in IE8.

Can someone please guide me to make ngTable work in IE8.

Thanks, Abhishek Hingu

abhishekhingu avatar Sep 19 '14 07:09 abhishekhingu

It says in the docs under the compatibility section:

https://github.com/esvit/ng-table#compatibility

sctskw avatar Oct 28 '14 14:10 sctskw

Hi abhishekhingu Were you able to get this working in ie8 using the compatibility pointed out by sctskw

I am running the demo's as localhost in IE8 (64 bit) but the table is not rendering. This is the error I am getting

TypeError: Object doesn't support this property or method<table class="table ng-scope" ng-table="tableParams" template-pagination="custom/pager">

All help will be highly appreciated.

Many thanks in advance

Thanks Dairy MIlk

dm7777 avatar Mar 13 '15 12:03 dm7777

Why was this closed ? Is there any resolution to this ?

yrshaikh avatar Jul 21 '15 08:07 yrshaikh

Hi,I got the same error in IE 8

hill-hu avatar Aug 01 '15 16:08 hill-hu

Guys,

I'm doing quite a bit of work on ngTable and to be honest IE8 isn't something I'm taking into account.

So for example, I'm not actively trying to limit usage of angular to < 1.3 features. Also, I'm about to add functionality that relies on Object.defineProperty which I don't think exists in IE8.

Now, that's not to say that it won't be possible to support IE8, but its not going to be my focus.

Realistically, you guys who need to support IE8 are going to have to either:

  1. maintain a separate branch
  2. contribute pull requests that will apply appropriate changes / shim's to allow the code base to support both

I can help coordinate getting to a suitable place where a branch can be taken if that is the approach taken.

C

christianacca avatar Aug 02 '15 16:08 christianacca

Hi Guys,

I fixed it replacing this two functions on JS:

if (!Array.prototype.map) { Array.prototype.map = function (fun /, thisp/) { var len = this.length;

    if (typeof fun != "function") throw new TypeError();

    var res = new Array(len);
    var thisp = arguments[1];

    for (var i = 0; i < len; i++) {
        if (i in this)
            res[i] = fun.call(thisp, this[i], i, this);
    }
    return res;
};

}

if (!Object.create) { Object.create = function (o, properties) { if (typeof o !== 'object' && typeof o !== 'function') throw new TypeError('Object prototype may only be an Object: ' + o); else if (o === null) throw new Error("This browser's implementation of Object.create is a shim and doesn't support 'null' as the first argument.");

    if (typeof properties != 'undefined') throw new Error("This browser's implementation of Object.create is a shim and doesn't support a second argument.");

    function F() { }
    F.prototype = o;

    return new F();
};

}

AdrianCuartas avatar Sep 08 '15 09:09 AdrianCuartas

@dm7777 Do you solve your problem?

Jesse121 avatar Jun 06 '16 07:06 Jesse121

@christianacca either make it work with IE8, or go and remove your message that it is compatible with IE<9 with JQuery 1 please. You can't keep that on the main page when it's utterly false.
I have implemented a full solution and then right when I come to testing - expecting it to work with IE8 as you claimed in the readme, it totally doesn't work and I have to come and find this issue to know that you actually stopped supporting IE8 in 2015 ffs.

worthy7 avatar Dec 26 '17 04:12 worthy7