Emiliano Suñé

Results 117 comments of Emiliano Suñé

This is - finally - ready for review.

> > Code looks good overall, I flagged a couple items that need to be looked at. Also wondering if it would make sense (and there is a way) to...

> I'm a bit unsure where this is at? I'll approve it though if you think it's good @amanji ? I think we need some more tweaks - see review...

> I've referenced the documentation on how the logging factory works > > https://docs.python.org/3/howto/logging-cookbook.html#customizing-logrecord > > I will also take another stab at filtering: > > https://docs.python.org/3/library/logging.html#filter-objects Thanks! I think...

> Thinking about it, we should probably tie the ability to **create new keys** to admin keys only. Yes, definitely - I didn't explicitly state it, but that would be...

I checked the code in ACA-Py, it appears that the acceptance metod is being cached at the `indy-vdr` global level rather than at the tenant profile level (see [here](https://github.com/hyperledger/aries-cloudagent-python/blob/4fa281a83491c9e5e6049baa9e49728127895df9/aries_cloudagent/ledger/indy_vdr.py#L952-L953) when...

Could be related to https://github.com/feathersjs/feathers/issues/3159

Thanks @WadeBarnes . Let's see how it goes after the upgrades and re-assess. If it is `MongoClient` that loses the connection and never recreates it we might have to look...

I believe this will require non-minor development and, possibly, getting away from SurveyJS altogether as an option. Currently, any field that is not displayed by SurveyJS will not be added...