esfuzz icon indicating copy to clipboard operation
esfuzz copied to clipboard

add support for UglifyJS parser (with Spidermonkey transform)

Open michaelficarra opened this issue 11 years ago • 14 comments

michaelficarra avatar Aug 21 '13 15:08 michaelficarra

Ugh. It looks like UglifyJS2 only supports taking SpiderMonkey ASTs as input, not creating them. I'll open up an issue and link to it.

edit: mishoo/UglifyJS2#275

michaelficarra avatar Aug 22 '13 03:08 michaelficarra

@michaelficarra I've closed issue with mishoo/UglifyJS2#526 and already used esfuzz (with some adaptations) for generative testing of UglifyJS->SpiderMonkey AST convertor itself. Check out mishoo/UglifyJS2#527 for details (hopefully it helps).

RReverser avatar Aug 03 '14 18:08 RReverser

I saw. Nice job. Care to open a PR when the new functionality is in an UglifyJS release?

michaelficarra avatar Aug 03 '14 18:08 michaelficarra

But you're using git://... dependencies for parsers, is it necessary to wait for the release?

RReverser avatar Aug 03 '14 18:08 RReverser

Ah, you're right. No it's not. Feel free to send a PR any time.

michaelficarra avatar Aug 03 '14 18:08 michaelficarra

I'd like to, and even started rewriting adapter to CoffeeScript, but the problem I have is actually the same as I mentioned in michaelficarra/CoffeeScriptRedux#315 (btw, could you please have a look at it?).

This project uses Makefiles and I use Windows. So we don't match each other (at least, without installing and configuring that Cygwin stuff) :(

That's why I love JS-based builders.

RReverser avatar Aug 03 '14 18:08 RReverser

This project uses Makefiles and I use Windows. So we don't match each other (at least, without installing and configuring that Cygwin stuff) :(

You don't need to, really. Just get some gnu stuff, or a git install that comes with all of this. Cygwin is one of the reason people hate windows - cmd.exe is not great, but at least it's not cygwin (others will suggest to use powershell).

vendethiel avatar Aug 03 '14 18:08 vendethiel

I have required subset of MinGW, but still it behaves pretty different from real Linux shell and sometimes fails (at least, I couldn't build CoffeeScriptRedux nor this project).

RReverser avatar Aug 03 '14 18:08 RReverser

I’ve tried many times, in many different ways to get make running on Windows, but never made it. (Then I switched to GNU/Linux and I haven’t looked back a second.)

lydell avatar Aug 23 '14 15:08 lydell

Just install msysgit and voilà, it works.

vendethiel avatar Aug 23 '14 17:08 vendethiel

Nope - it doesn't :P At least for this project or CoffeeScriptRedux.

RReverser avatar Aug 23 '14 17:08 RReverser

Well, I remember fixing Redux's makefile once upon a time. Or maybe it was the "coffeescript-project" structure.

vendethiel avatar Aug 23 '14 17:08 vendethiel

Just install msysgit and voilà, it works.

As far as I remember, make isn't even included in msysgit.

lydell avatar Aug 23 '14 18:08 lydell

Oh, isn't it? Must be in ruby's toolset-thingie,then. My bad.

vendethiel avatar Aug 23 '14 19:08 vendethiel