escodegen icon indicating copy to clipboard operation
escodegen copied to clipboard

Published 20 hours ago • verified publisher icon estools

Nullish coalescing support

Open sanex3339 opened this issue 4 years ago • 19 comments

I have no idea what I'm doing but it works. Probably it can be done in a more simple way.

sanex3339 avatar Jun 23 '20 20:06 sanex3339

@bakkot, @michaelficarra Now let's do this!

sanex3339 avatar Aug 06 '20 06:08 sanex3339

Looks like this one will take a bunch of the time too =(

sanex3339 avatar Aug 14 '20 05:08 sanex3339

@bakkot may you review this please? It would be nice to get this in good form before @michaelficarra see this.

sanex3339 avatar Aug 15 '20 06:08 sanex3339

@michaelficarra any news?

sanex3339 avatar Aug 20 '20 06:08 sanex3339

And again two months have passed since the PR was created and still no response =(

sanex3339 avatar Aug 22 '20 09:08 sanex3339

@bakkot thank you, i updated the PR: https://github.com/estools/escodegen/pull/417/commits/5646f113ae78eca9046da1b8e4ea20d4baec87ad

sanex3339 avatar Aug 24 '20 05:08 sanex3339

@michaelficarra may you check it now?

sanex3339 avatar Aug 25 '20 01:08 sanex3339

@michaelficarra ping. Please check this.

sanex3339 avatar Sep 01 '20 06:09 sanex3339

@michaelficarra ping

sanex3339 avatar Sep 12 '20 08:09 sanex3339

@michaelficarra this PR is still here. 3 months have left since it was created.

sanex3339 avatar Sep 17 '20 11:09 sanex3339

@michaelficarra @Constellation ping Let's celebrate the 3rd month that is passed without any attention to this PR.

sanex3339 avatar Sep 23 '20 06:09 sanex3339

@michaelficarra ping

sanex3339 avatar Sep 28 '20 07:09 sanex3339

@michaelficarra please check this

sanex3339 avatar Oct 02 '20 18:10 sanex3339

@michaelficarra ping

sanex3339 avatar Oct 07 '20 21:10 sanex3339

@michaelficarra ping

sanex3339 avatar Oct 12 '20 20:10 sanex3339

Seems it's definitely the time to create a fork.

sanex3339 avatar Oct 17 '20 20:10 sanex3339

@michaelficarra Ping

sanex3339 avatar Oct 20 '20 18:10 sanex3339

@michaelficarra last ping in hope that it will be merged and I wont create a fork with all my PRs

sanex3339 avatar Oct 31 '20 10:10 sanex3339

I created the fork with this feature: https://www.npmjs.com/package/@javascript-obfuscator/escodegen

sanex3339 avatar Nov 04 '20 18:11 sanex3339