escodegen icon indicating copy to clipboard operation
escodegen copied to clipboard

Build for the consumer

Open lastmjs opened this issue 7 years ago • 7 comments

I'm running into issues with this repo because the assets aren't built already for me. Now I'm going to have to manually go in and do an npm install and run the script to build. I might have to fork the repo so that I can change the package.json to do this for me, or just commit the built files. Why not build it for us? Or just add a post install script or something?

lastmjs avatar Jul 05 '17 08:07 lastmjs

@lastmjs Are you talking about the browser build? I'd accept a PR to include the browser build in the npm package. But I'm strongly against keeping built files in the git repo.

michaelficarra avatar Jul 05 '17 16:07 michaelficarra

Great, I might take you up on that then.

lastmjs avatar Jul 06 '17 03:07 lastmjs

It looks like tools/release.js is pretty out of date. @michaelficarra what's the current release process like?

gabejohnson avatar Jan 03 '18 20:01 gabejohnson

@gabejohnson I'll make a release soon.

michaelficarra avatar Jan 31 '18 08:01 michaelficarra

I'd love to have a browser build easily available. I'm trying to work out how to build it from the npm package but I'm a beginner with node. Makes it hard to get at.

tomgallagher avatar Mar 10 '18 01:03 tomgallagher

I'm interested in this as well. I'm a bit confused about the state of the releases anyway. It seems that the release tags starting at 1.7.0 no longer contain the built browser files, which seems to also affect the bower releases too.

I tried toying a bit with the tools/release.js script, but I couldn't figure out how this is supposed to work, or why the built files aren't present in github or in npm files. The .npmignore file seems to indicate we wouldn't publish the file escodegen.browser.js, but the file escodegen.browser.min.js should be present at a minimum.

Were the latest npm releases done without the release script by any chance ?

nicolasnoble avatar Apr 16 '18 23:04 nicolasnoble

I think I figured it out. See #368 as a proposed change for this.

nicolasnoble avatar Apr 16 '18 23:04 nicolasnoble