escodegen icon indicating copy to clipboard operation
escodegen copied to clipboard

Add support for inline comments

Open gadisn opened this issue 8 years ago • 7 comments

In regard to issue #206 ("Attach comment to an empty object"):

I have an initial modification of attachComments() and addComments() which supports comments in empty object/block.

I've called them inline comments, and they are attached to the node which represents the empty object/block (i.e. ObjectExpression/BlockStatement).

gadisn avatar Jun 06 '16 05:06 gadisn

You'll need to add tests before this can be accepted.

michaelficarra avatar Jun 06 '16 06:06 michaelficarra

Sure, I'll add tests, and will fix my code so the existing tests which are failing will pass.

gadisn avatar Jun 06 '16 09:06 gadisn

Whats the status on this. I have a node module that exports a set of constants and all my inline comments are lost because they exist at the body level (no node to attach to). I could really use this functionality.

Cleanshooter avatar Apr 04 '17 16:04 Cleanshooter

@Cleanshooter Looks like it still needs tests.

michaelficarra avatar Apr 09 '17 18:04 michaelficarra

@Cleanshooter Add tests, so this can get merged

tonyobanon avatar Apr 04 '20 10:04 tonyobanon

@tonyobanon You can add tests, too. It's open source after all.

michaelficarra avatar Apr 04 '20 13:04 michaelficarra

@tonyobanon why would I? I last posted a comment on this project 3 years ago. I don't even know what this thing is anymore. Probably be a good idea to not call out people that haven't been involved with a project for years to do stuff for you in the future... 🙄

Cleanshooter avatar Apr 04 '20 14:04 Cleanshooter