Results 139 comments of estk

@Ruijuan-Cao can you give an example?

@caoruijuan13 the `log` crate does not have a notion of structured logging, I would suggest that you use an empty formatter and serialize the json output yourself. Using a separate...

@peamaeq First, I appreciate the PR and really appreciate others taking a critical eye to log4rs. My concern here is that we're not actually making things any safer and that...

@Coding-Badly that sounds like it could be an issue, would you be interested in working on a fix?

@Coding-Badly any other solution you can think of that wouldn't break the current API?

I like that idea, I would prefer to not deprecate the current method as I think that will be the 99% use case, but certainly, we should mention the limitation...

@abmpicoli I'm not sure the problem that you're talking about is solvable without violating the "Principle of least astonishment" but I would be happy to mentor you as you take...

Hi @SarthakSingh31 , Thanks for the suggestion. I have a few questions about the proposal. How would you handle precedence of the config options? For instance would `combine` overwrite every...

@Coding-Badly This change makes sense, there are a few other breaking changes that I'd like to make so maybe we'll keep this open for a bit while we proceed towards...