estk
@cristiano-prato Thanks so much for the excellent contribution. One question I had was: what happens when a user does not have zstd installed? Other than that it lgtm
completed
@blizzardzheng does https://docs.rs/log4rs/latest/log4rs/config/index.html#encoder answer your question?
@TuEmb looks like merge is blocked on conflicts
oh i see what happened, there's a merge commit, I'll just squash this then fix it in post. Thanks for your help with this.
I am unsure how we could reasonably reproduce this. I'm going to leave it open for now.
closing for now
This review is in my queue. Thanks for your patience @Creative-Difficulty
@Creative-Difficulty please rebase and resolve the conflicts and I will review this week.
You'll need to modify the tests to verify the original and the serialize-> deserialize versions are **equivalent** not necessarily identical.