windmill-react-ui icon indicating copy to clipboard operation
windmill-react-ui copied to clipboard

feat(pagination): added support to programmatically change active page

Open tomisykora opened this issue 5 years ago • 3 comments

Hi @estevanmaito ! There are cases where users needs to programmatically change the active page number, eg. when searching, the page should change to first page. So that's what has been added here in this pull request. I also added Pagination storybook and test coverage for this use case. Thanks in advance for looking into it! 😊

This resolves #42

tomisykora avatar Mar 17 '21 08:03 tomisykora

Codecov Report

Merging #44 (5e1145a) into master (b7afcfd) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          495       495           
  Branches        77        77           
=========================================
  Hits           495       495           
Flag Coverage Δ
unittest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Pagination.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7afcfd...5e1145a. Read the comment docs.

codecov[bot] avatar Mar 17 '21 08:03 codecov[bot]

The change looks good , any reason why this is not merged yet? @estevanmaito

IvanTodorovv avatar Mar 11 '22 10:03 IvanTodorovv

I need this also, please merged this..

kenjoesavandal avatar Mar 16 '22 10:03 kenjoesavandal