k8s-image-swapper icon indicating copy to clipboard operation
k8s-image-swapper copied to clipboard

Bump golang from 1.18 to 1.20

Open krmichelos opened this issue 1 year ago • 7 comments

Golang 1.20 is the oldest version that is supported

krmichelos avatar Nov 01 '23 13:11 krmichelos

@estahn, do you need anything from me?

krmichelos avatar Nov 17 '23 13:11 krmichelos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (123ee5b) 34.08% compared to head (31f9a68) 34.08%. Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   34.08%   34.08%           
=======================================
  Files           9        9           
  Lines         848      848           
=======================================
  Hits          289      289           
  Misses        534      534           
  Partials       25       25           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 19 '23 23:11 codecov[bot]

I am mostly offline until after Thanksgiving, but I will take a look at the failures when I am back if it is still an issue.

krmichelos avatar Nov 21 '23 21:11 krmichelos

@krmichelos Thanks. I'm travelling over the next couple of weeks, so have limited time myself.

estahn avatar Nov 21 '23 21:11 estahn

@estahn I believe I have all the lint related issues resolved

krmichelos avatar Nov 28 '23 14:11 krmichelos

@estahn, I know it is a busy time of year, but would you be able to approve the tests to run so I can see if they pass?

krmichelos avatar Dec 14 '23 18:12 krmichelos

I will be mostly unavailable until after the new year

krmichelos avatar Dec 22 '23 15:12 krmichelos