k8s-image-swapper icon indicating copy to clipboard operation
k8s-image-swapper copied to clipboard

Published 20 hours ago • verified publisher icon estahn

Addition of generic registry

Open johnmehan opened this issue 1 year ago • 9 comments

Added a generic registry allowing k8s-image-swapper to be used with registries that use username/password.

johnmehan avatar Oct 23 '23 14:10 johnmehan

Also interested in having this in.

towolf avatar Nov 28 '23 21:11 towolf

@johnmehan we would like to deploy a simple local Docker registry without auth. Would that also be supported?

towolf avatar Nov 29 '23 08:11 towolf

From my testing, it looks like this forces defining every source registry and will error out on any images are not from a registry in the list. It also forces adding creds to all of them. @johnmehan I've PR'd your repo with an additional modification to enable using anonymous copies (both on source and destination) and also without defining creds for everything.

@towolf While waiting for this to be merged eventually I pushed an image to inputobject2/k8s-image-swapper:v1.5.9-noauth that I'm using without issue in my homelab.

InputObject2 avatar Dec 07 '23 02:12 InputObject2

@InputObject2 I've merged your changes. Thanks!

johnmehan avatar Dec 07 '23 15:12 johnmehan

@estahn this PR might also close #29 and #30

InputObject2 avatar Feb 13 '24 20:02 InputObject2

@estahn would love to see this get merged. I think I'm going to need to build this w/ the PR and run my own container in the meantime.

rattboi avatar Jun 01 '24 02:06 rattboi

hi @estahn , I'm curious if you've found time to review this.

rattboi avatar Jun 17 '24 20:06 rattboi