estafette-gke-preemptible-killer icon indicating copy to clipboard operation
estafette-gke-preemptible-killer copied to clipboard

[👌 IMPROVE] test script

Open andrei-pavel opened this issue 4 years ago • 2 comments

  • kind syntax has changed, make it work with kind version 0.7.0
  • rather than cleaning up at the end, use traps to cleanup in case script fails mid-way
  • rather than timing out the killer for five seconds and hope it has written the annotations by then, wait for the killer to finish by looking into what it writes to standard output and then send a kill signal to finish the killer which the timeout already did before anyway, there's no compromise there, the script now ends instantaneously from the second run onwards since on the first run it creates the kind cluster

andrei-pavel avatar Feb 26 '20 20:02 andrei-pavel

Specifically, this is the kind command that didn't work anymore:

kind get kubeconfig-path --name='kind'

And it's deprecation is documented somewhere around here: https://github.com/kubernetes-sigs/cluster-api/issues/1796

andrei-pavel avatar Feb 26 '20 20:02 andrei-pavel

one month celebration, although pull requests don't age well like fine wine, is there anything I can do to speed things up?

andrei-pavel avatar Mar 29 '20 22:03 andrei-pavel