chipmunk
chipmunk copied to clipboard
Implementation for text_grep - Issue (Searcher (rustcore) #1715)
@itsmesamster thanks for PR. I have a couple of comments in general:
- do not mix
asyncand stuff fromstd. I'm aboutthreads,channelsetc fromstd... If you need to spawn something it should be really motivated and we should usetokioto do it (because it's major framework for chipmunk) - try to keep away from
Arc,Mutexetc... many use-cases can be resolved avoiding it. - make sure you do not post any into terminal... It's crate/lib - it should return status. We can post something only for debugging
- please define
Errorenum for errors of your crate. Take a look tothiserrorcrate, which can be useful for string converting - please add some information about measurements...
Some random measurements and proof that the count is correct as per ripgrep, depending on the case sensitivity flag.