chipmunk icon indicating copy to clipboard operation
chipmunk copied to clipboard

find replacement for `buf_redux` library

Open marcmo opened this issue 2 years ago • 4 comments

library is not supported anymore

marcmo avatar Jun 19 '23 10:06 marcmo

I think one of the best candidates is the crate bytes I'll make some research about it and try to replace it while exploring the source code

AmmarAbouZor avatar Jan 17 '24 18:01 AmmarAbouZor

I don't think we can use the crate bytes to replace buf_redux because it doesn't support handling reading from a file directly but rather it works with in-memory bytes only.

I've found the maintained fork buffer_redux, which still hasn't commited changes on the original code besides updating the dependencies, adding CI Pipelines and applying cargo clippy fixes.

I would suggest trying this crate in a draft PR where we can test it and then we can merge if everything is still working fine. We will need to to merge buffer_redux change in Dmitry's fork as well.

AmmarAbouZor avatar Jan 20 '24 19:01 AmmarAbouZor

@AmmarAbouZor last time we discussed with @marcmo the possibility to maintain buf_redux crate as well. It isn't a huge lib and already includes some of our changes. @marcmo it looks like it make sense to make a fork of buf_redux in esrlabs and re-register it also on crates.io. What do you think?

DmitryAstafyev avatar Jan 22 '24 08:01 DmitryAstafyev

It would be very interesting to maintain the crate, since it's really low level and has its share of low level implementation across different operating systems and unsafe code.

AmmarAbouZor avatar Jan 22 '24 19:01 AmmarAbouZor