BangleApps icon indicating copy to clipboard operation
BangleApps copied to clipboard

Add new fun facts to Fact list

Open RKBoss6 opened this issue 6 months ago • 3 comments

Added many more fun facts, removed redundant ones. eg. (Koalas are native to australia, Koalas are only found in australia)

RKBoss6 avatar Jun 26 '25 01:06 RKBoss6

Looks great to me, thanks!

Just checking - this is tested and works?

gfwilliams avatar Sep 02 '25 10:09 gfwilliams

I'm actually not sure what the issue is, but each fact when pulled is a mashup of other facts (ippos. A group of ravens i)

RKBoss6 avatar Sep 02 '25 15:09 RKBoss6

That would have been handy to know in the PR!

You need to run this code and use the idx and count values it prints:

https://github.com/espruino/BangleApps/blob/4bb0e47660cf38b0b396ad9fa50ed376f4042b8d/apps/textfacts/lib.js#L6-L21

I guess you did run them before, but count is 237 and yet there are 316 lines so I guess maybe it was run on out of date data?

gfwilliams avatar Sep 02 '25 15:09 gfwilliams

@RKBoss6 any chance of fixing this? If you run the code again with the new data and update the library file it should be fine

gfwilliams avatar Dec 05 '25 09:12 gfwilliams

Oh yeah, I had put this aside for a while, I'll get this working :)

RKBoss6 avatar Dec 05 '25 17:12 RKBoss6

I think it's fixed now!

RKBoss6 avatar Dec 05 '25 18:12 RKBoss6

Thanks for dealing with this - Copilot is very picky!

gfwilliams avatar Dec 08 '25 10:12 gfwilliams

Hehe no worries! Glad this 6 month old PR was finally ready to merge :)

RKBoss6 avatar Dec 08 '25 11:12 RKBoss6