BangleApps icon indicating copy to clipboard operation
BangleApps copied to clipboard

Updates to 2 apps, including 1 new one (HeatSuite) - merged commits

Open nravanelli opened this issue 10 months ago • 10 comments

As requested by @thyttan, I merged the commits for each app.

Specific changes below:

coretemp: Revised the application to be more like the BTHRM app. Added the ability to pair an ANT+ heart rate strap directly to the CORE Sensor so it can use the exertional algorithm when HR > 120 BPM.

gpssetup: Added adaptive mode where it can scan for GPS signals more frequently if a signal was found. Otherwise, reverts back to normal scan interval.

heatsuite: New app.

nravanelli avatar Apr 25 '25 03:04 nravanelli

Internal testing on the HeatSuite widget and fixed the miss-handling of rr intervals and heatflux from the BTHRM and coretemp sensor, respectively.

nravanelli avatar Apr 30 '25 08:04 nravanelli

Please say when you want me to look at merging :)

thyttan avatar May 05 '25 08:05 thyttan

Go for it @thyttan :)

nravanelli avatar May 05 '25 08:05 nravanelli

Ok! Will try to get to it tonight 👍

thyttan avatar May 05 '25 08:05 thyttan

Cool project!

Some notes from testing:

  • The widget seems to invert the background colour.
    • But it looks intentional - so like it should be? Looks kindof nice!
      • In that case maybe you'd want to invert some of the dark dots in the icon when the background is dark? just a thought.
  • Trying to start Core Temp I get:
 ____                 _
|  __|___ ___ ___ _ _|_|___ ___
|  __|_ -| . |  _| | | |   | . |
|____|___|  _|_| |___|_|_|_|___|
         |_| espruino.com
 2v25.378 (c) 2025 G.Williams
Uncaught undefined
Uncaught Error: Function "setCORESensorPower" not found!
 at line 11 col 784 in coretemp.app.js
....getHeight()/2+16);}Bangle.setCORESensorPower(1,"COREAPP");B...
                              ^
> 
  • Most of the HeatSuite icon is invisible on dark theme: image
    • I don't think you must update it, but maybe it makes sense to invert the dark dots? But maybe it's unnecessary hassle.
  • Widgets decided to draw over the HeatSuite UI: image
    • but it may be a quirk of my watch setup - not sure!
    • This happened when clicking either of the two red buttons (top right).
  • It says Searching... in the bottom - is it looking for a GPS fix?
  • I suggest you add a screenshot of the app ui and describe what the different buttons do in the README.
  • Clicking the scale button (bottom left) does nothing for me? (I don't have a scale connected)
  • HeatSuite seems add a swipe gesture on the clock face for starting the app?
    • Is that intended? If so, please document it in the README.
    • I'd suggest a setting so it can be toggled off.
  • HeatSuite seemed to disable much of my bootcode apps.
    • But I think that will maybe be fixed when this typo is gone: https://github.com/espruino/BangleApps/pull/3827#discussion_r2074143421
    • Easily fixed by uninstalling HeatSuite and rewriting settings from the setting app utils.

thyttan avatar May 05 '25 21:05 thyttan

Great - this seems to be working fine now!

I'll just give @hughbarney a day or two to look at gpssetup and @ihewitt at coretemp as creators of respective app, if they should spot something.

Also, if you could split 2e85c3570cd1c21fdb18af95ab86b701ea69a766 so it becomes two commits, one for coretemp and one for heatsuite?

Thanks again! ☀️

thyttan avatar May 07 '25 19:05 thyttan

I just noticed, the icon is not centered on the watch: image

Compare with PA Remote: image

I will not hold the PR back for this, but polish is always nice (which Heatsuite has plenty!).

thyttan avatar May 07 '25 20:05 thyttan

Here's a guide on interactive rebasing, where the "edit" command will be useful: https://docs.github.com/en/get-started/using-git/using-git-rebase-on-the-command-line

I'd maybe suggest making a test or backup branch so you don't risk losing anything, in terminal:

git switch master;
git switch --create myBackup;
git whatchanged;   <-- verify all your commits are in the backup branch
git switch master;
git rebase --interactive;    <-- now follow the guide linked above

thyttan avatar May 07 '25 23:05 thyttan

It would be nice, but if it feels too cumbersome I wont force you.

thyttan avatar May 07 '25 23:05 thyttan

Great - this seems to be working fine now!

I'll just give @hughbarney a day or two to look at gpssetup and @ihewitt at coretemp as creators of respective app, if they should spot something.

Cool, looks great. I'll take a look but won't be until next week since I'm traveling.

ihewitt avatar May 08 '25 12:05 ihewitt

Thanks @ihewitt!

@thyttan merge ready when you are. I just fixed the conflicts with webtools

nravanelli avatar May 15 '25 03:05 nravanelli

Yes lets merge this soon 🙂

Just spotted one thing to run by Gordon.

thyttan avatar May 15 '25 12:05 thyttan

Yes lets merge this soon 🙂

Just spotted one thing to run by Gordon.

That’s an experimental feature I’ve been working on locally, in process of validating it. Didn’t realize it creeped into my pull request branch, sorry.

can ignore it as I’ll dev a custom branch and push to my master once the feature works and is valid.

nravanelli avatar May 15 '25 13:05 nravanelli

Ok here we go :)

Thanks!

thyttan avatar May 16 '25 17:05 thyttan