espruino
Add support for reply lib to messagegui app
Adds support for the canned responses/reply lib to the default messagegui app.
By clicking on a notification to head to the notification settings, the user will see a "reply" menu item if the message can be replied to, which will trigger the reply library flow
@soneret was eager to try this in https://github.com/espruino/BangleApps/pull/3473#issuecomment-2227525727.
If I'm correct this update can be installed from https://whelanb.github.io/BangleApps/?id=messagegui , right @WhelanB ? :)
I want to try it some myself and we should wait for @gfwilliams to be back so he can chime in as well before we merge.
@soneret was eager to try this in #3473 (comment).
If I'm correct this update can be installed from https://whelanb.github.io/BangleApps/?id=messagegui , right @WhelanB ? :)
I want to try it some myself and we should wait for @gfwilliams to be back so he can chime in as well before we merge.
Yes! it's hosted there now if you want to point Gadgetbridge to that link :) Let me know if you hit any issues running it! happy to wait for Gordon to approve
This looks great, thanks! Just the 2 comments above. It'll be good to have the ability to do proper replies.
I guess maybe later we might even want to make swipe right reply to a message if it supports replies?
This looks great, thanks! Just the 2 comments above. It'll be good to have the ability to do proper replies.
I guess maybe later we might even want to make swipe right reply to a message if it supports replies?
I've just pushed an update to address the PR comments, and add swipe right to reply! spotted some issues around empty replies as well in the reply lib that are now handled
tested out the new version and found a bug, once you receive a message and reply to it, the message popup again and can not be dismissed (as in it remains in the messages app and can not be removed without disconnecting from the phone). This may just be an android issue, im not sure
Update: it seems to be an issue with how google messages handles replies via notifications, signal works fine the notification appears twice but its dismissed once I swipe left
Sorry for the slow reply on this - @RelapsingCertainly is it that the notification isn't actually dismissed on your phone after replying and so stays present on the Bangle? I've mostly testing on apps like Whatsapp, where the notification is dismissed by Whatsapp after replying and so gets deleted from the Bangle, but I know some apps (like Discord, which doesn't support reply over Bangle atm) keeps the notification around, so maybe I need to handle that case
When I get a text message on Google Messages, I can reply to it as usual and it sends successfully. However, the message notification repeats on my watch (and not on the phone), allowing me to reply again. Even after dismissing it on the watch, the notification remains in the Messages app.
I don’t think this is related to the recent pull since a similar issue occurred with music notifications not dismissing.
@RelapsingCertainly I'm not sure this is something others are seeing - but perhaps if you could post up a Gadgetbridge log file then we can see what's actually going on.
Oh that's weird. When I tried to recreate the bug it has seemingly fixed itself. I'm so confused but looks like no fix is needed anymore :/
Also thing to note: the bug also fixed itself on my "dynamic island" app so it might have been a bug from google and now its fixed
@WhelanB question: are there any plans re add the ability to dismiss the notification without replying? What I mean is sending an affermative action to open the app on my phone. Kind of how its like it is when you cant reply.
This is mostly useful when getting a notification but I dont have the time to respond but also dont want to clear the notification or have the flashing icon.
In future we could add a toggle for whether you want to be able to reply or ack the message from swipe right, but I think for this PR I'll keep the behaviour limited to swipe right to reply for messages that support it
email and other apps reply possible e.g aliexpress
Android için BlueMail uygulamasını edinin
On 13 Ağu 2024 22:40 , at 22:40 , Brian Whelan @.***> yazdı:
In future we could add a toggle for whether you want to be able to reply or ack the message from swipe right, but I think for this PR I'll keep the behaviour limited to swipe right to reply for messages that support it
-- Reply to this email directly or view it on GitHub: https://github.com/espruino/BangleApps/pull/3513#issuecomment-2286997152 You are receiving this because you were mentioned.
Message ID: @.***>
@gfwilliams is there anything stoping this pull from being merged? I have been testing for a while and it seems to be ready for stable.
email and other apps reply possible e.g aliexpress Android için BlueMail uygulamasını edinin On 13 Ağu 2024 22:40 , at 22:40 , Brian Whelan @.> yazdı: … In future we could add a toggle for whether you want to be able to reply or ack the message from swipe right, but I think for this PR I'll keep the behaviour limited to swipe right to reply for messages that support it -- Reply to this email directly or view it on GitHub: #3513 (comment) You are receiving this because you were mentioned. Message ID: @.>
I think this would need to be handled on the Gadgetbridge side, rather than here. I'd like to take a look at at some point since it has some support for canned responses already, and doesn't support some apps like Discord currently.
@gfwilliams is there anything stoping this pull from being merged? I have been testing for a while and it seems to be ready for stable.
Yeah, I don't think there's much more on my side for this PR, so if it's looking good would be great to get this merged!
Thanks - yes, this looks good to me. Merging now!
Sorry for the delay, I've been on/off holiday a bit the last few weeks
Check the Development App Loader - accessible from the "More..." tab of the official App Loader. Updates show up there virtually as soon as they are merged here in the repo.
Gordon updates the official App Loader manually with some delay so we have a chance to fix bugs if they appear on the development one.