fix(environment): Clone IDF release branches instead of downloading zip and then fastforward
When the selected IDF branch is the release one, perform git clone instead of downloading a zip archive and fast-forwarding to the latest commit
Releated
- based on the Mattermost discussion (mention in tracker)
- internal tracker: IDF-10228
Tested
- online IDF Installer (GitHub, Gitee and JihuLab mirrors)
- release branch (zip archive correctly NOT downloaded -> git clone performed)
- master branch (zip archive correctly NOT downloaded -> git clone performed)
- released IDF version (zip archive correctly downloaded)
- offline IDF Installer (working as usual without any issues)
FYI @leeebo
Honestly, I’m not entirely satisfied with this approach, but given the "feature freeze" (if I understood correctly) on the Windows IDF Installer, it seems like a reasonable compromise without requiring a more complex refactor.
That said, I’m open to any suggestions if you have a better approach in mind guys.
@igrr, thanks for the review! I have implemented the changes as you suggested so it should be ready to merge. I have tested the installer and it works as expected.
Unfortunately, I am not able to do the merge as we agreed without your re-review and approval since you are the maintainer and requested a change.