idf-installer icon indicating copy to clipboard operation
idf-installer copied to clipboard

fix(environment): Clone IDF release branches instead of downloading zip and then fastforward

Open jakub-kocka opened this issue 1 year ago • 1 comments

When the selected IDF branch is the release one, perform git clone instead of downloading a zip archive and fast-forwarding to the latest commit

Releated

  • based on the Mattermost discussion (mention in tracker)
  • internal tracker: IDF-10228

Tested

  • online IDF Installer (GitHub, Gitee and JihuLab mirrors)
    • release branch (zip archive correctly NOT downloaded -> git clone performed)
    • master branch (zip archive correctly NOT downloaded -> git clone performed)
    • released IDF version (zip archive correctly downloaded)
  • offline IDF Installer (working as usual without any issues)

jakub-kocka avatar Sep 11 '24 10:09 jakub-kocka

FYI @leeebo

Honestly, I’m not entirely satisfied with this approach, but given the "feature freeze" (if I understood correctly) on the Windows IDF Installer, it seems like a reasonable compromise without requiring a more complex refactor.

That said, I’m open to any suggestions if you have a better approach in mind guys.

jakub-kocka avatar Sep 11 '24 13:09 jakub-kocka

@igrr, thanks for the review! I have implemented the changes as you suggested so it should be ready to merge. I have tested the installer and it works as expected.

Unfortunately, I am not able to do the merge as we agreed without your re-review and approval since you are the maintainer and requested a change.

jakub-kocka avatar Nov 01 '24 10:11 jakub-kocka