idf-extra-components icon indicating copy to clipboard operation
idf-extra-components copied to clipboard

Change/led strip dependency

Open suda-morris opened this issue 1 year ago • 1 comments

Closes https://github.com/espressif/idf-extra-components/issues/361

suda-morris avatar Aug 12 '24 02:08 suda-morris

@suda-morris thanks for the PR! LGTM aside from two questions.

igrr avatar Aug 12 '24 06:08 igrr

@suda-morris could you please also bump the version in idf_component.yml, so that the changes get released? And update the changelog file.

igrr avatar Aug 14 '24 05:08 igrr

@suda-morris could you please also bump the version in idf_component.yml, so that the changes get released? And update the changelog file.

Hi @igrr Do we want to bump the version every time we made a change? This change doesn't affect the functionality of led_strip in fact, so I want to bump the version in the next time when we have a new feature or a bugfix. e.g. in https://github.com/espressif/idf-extra-components/pull/344

suda-morris avatar Aug 14 '24 07:08 suda-morris

I think it does improve developer experience because the time for the full build with IDF v5.3 can now be shorter. So from my perspective, it's worth publishing the release. Besides, there is almost no cost associated with publishing the new version.

If you plan to merge #344 soon then I don't mind bumping the version after that one, either.

Still, I would add a changelog entry as part of this PR so that this change isn't forgotten about.

igrr avatar Aug 14 '24 07:08 igrr