idf-eclipse-plugin icon indicating copy to clipboard operation
idf-eclipse-plugin copied to clipboard

IEP-1656 Update LSP4E to the 0.29.0

Open sigmaaa opened this issue 1 month ago β€’ 2 comments

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-1656)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • [ ] PR Self Reviewed
  • [ ] Applied Code formatting
  • [ ] Added Documentation
  • [ ] Added Unit Test
  • [ ] Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Chores
    • Updated Language Server Protocol support to the latest version, enhancing IDE integration and development environment stability.

sigmaaa avatar Nov 18 '25 11:11 sigmaaa

Walkthrough

Updated the InstallableUnit version for LSP4E from 0.27.10 to 0.29.0 in the target definition file. The change only alters the source/version of the LSP4E bundle; other LSP4E/LSP4J units and locations remain unchanged.

Changes

Cohort / File(s) Summary
LSP4E Version Bump
releng/com.espressif.idf.target/com.espressif.idf.target.target
Updated InstallableUnit for LSP4E from version 0.27.10 to 0.29.0 (source/version change only)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify compatibility of LSP4E 0.29.0 with existing LSP4E/LSP4J dependencies and build.
  • Spot-check target resolution and plugin startup with updated target.

Possibly related PRs

  • espressif/idf-eclipse-plugin#1317 β€” Previously set LSP4E InstallableUnit to 0.27.10; directly related target-definition changes.
  • espressif/idf-eclipse-plugin#1245 β€” Prior update to LSP4E in the same target definition (related file-level edits).

Suggested reviewers

  • alirana01
  • kolipakakondal

Poem

🐰 I hopped from .10 to .29 with glee,
A tiny bump for LSP, a spring in me.
Bundles updated, target sings,
Quiet changes, hopeful springs. ✨

Pre-merge checks and finishing touches

βœ… Passed checks (3 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed The title 'IEP-1656 Update LSP4E to the 0.29.0' directly and clearly describes the main change: updating LSP4E dependency to version 0.29.0, which matches the raw summary and PR objectives.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch IEP-1656

πŸ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 768f2f79f32819e6a4d0124458f84b73f1198174 and 25e65d04e43490ef9453a8e717d19a5bc437682c.

πŸ“’ Files selected for processing (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 18 '25 11:11 coderabbitai[bot]

Hi @kolipakakondal, @AndriiFilippov,

With this PR, the new option now appears under the Language Server settings:

image

This option fixes the new-line indentation issue on Linux and macOS.

sigmaaa avatar Nov 20 '25 08:11 sigmaaa

@sigmaaa hi !

Tested under: OS: Windows 11 / Mac ARM64 / Linux Ubuntu

the new-line indentation issue fixed :heavy_check_mark:

LGTM :+1:

AndriiFilippov avatar Nov 24 '25 13:11 AndriiFilippov