Draft - fix: restart lsp server without shutdown

[sigmaaa]

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Test Configuration:

• ESP-IDF Version:
• OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

• Component 1
• Component 2

Checklist

• [ ] PR Self Reviewed
• [ ] Applied Code formatting
• [ ] Added Documentation
• [ ] Added Unit Test
• [ ] Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

• Refactor
  • Disabled the automatic restart of language servers to improve stability. No changes to visible features or user workflow.

[coderabbitai[bot]]

Walkthrough

The restartLspServers() method in LspService.java was disabled by commenting out its entire implementation, removing both asynchronous shutdown-restart logic and synchronous restart calls. The method no longer performs any operations on language server wrappers while retaining its original signature.

Changes

File(s)	Change Summary
bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java	Disabled the entire implementation of restartLspServers() by commenting out all restart logic, including async shutdown and synchronous restart calls.

Possibly related PRs

• espressif/idf-eclipse-plugin#1021: Modifies imports and exception handling in LspService.java, related by file and method but not by restart logic.
• espressif/idf-eclipse-plugin#1171: Refactors restartLspServers() to use asynchronous shutdown and restart, directly related as it changes the same method with a different approach.
• espressif/idf-eclipse-plugin#1155: Adds a method that calls restartLspServers() to refresh LSP servers when switching projects, related by usage of the same method.

Suggested reviewers

• kolipakakondal
• AndriiFilippov

Poem

A hop, a skip, the servers rest,
No restarts now, they take a rest.
Async calls all tucked away,
Quiet LSPs for today.
In silent fields the code does play,
Awaiting hops another day.
🐇🌿✨

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd465e2f27c9ebfa1da6b23b265cda6e89bd1715 and 425d2d1d7de56a60edce73a31ad97be0c4f98a02.

📒 Files selected for processing (1)

• bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• bundles/com.espressif.idf.core/src/com/espressif/idf/core/util/LspService.java

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build_macos
• GitHub Check: build

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sigmaaa]

The issue still occurs even without our restart method, so it's not related to that. Continuing to investigate.