idf-eclipse-plugin icon indicating copy to clipboard operation
idf-eclipse-plugin copied to clipboard

SWTBot test case: Partition Table Editor

Open AndriiFilippov opened this issue 1 year ago • 4 comments

Description

add Partition Table Editor test cases.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [ ] PR Self Reviewed
  • [ ] Applied Code formatting
  • [ ] Added Documentation
  • [ ] Added Unit Test
  • [ ] Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Tests
    • Introduced a new automated test for the Partition Table Editor to validate its functionality with newly created projects.
    • Updated methods for installing new components and refreshing projects to streamline command execution through a unified approach.
    • Added new methods to enhance verification of UI elements and partition table contents during testing, improving overall test coverage.

AndriiFilippov avatar Jul 01 '24 11:07 AndriiFilippov

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This pull request introduces comprehensive modifications to the Espressif IDF UI testing framework. The changes primarily focus on refactoring test classes, enhancing test operations, and updating build configurations. Key modifications include commenting out several test methods in NewEspressifIDFProjectTest, introducing a new NewEspressifIDFProjectPartitionTableEditorTest class, updating environment setup and project test operations, and adjusting the project's Maven configuration to improve testing resource allocation.

Changes

File Change Summary
tests/com.espressif.idf.ui.test/.../NewEspressifIDFProjectTest.java - Commented out multiple test methods
- Updated build and component installation test methods
- Modified console output assertion logic
tests/com.espressif.idf.ui.test/.../NewEspressifIDFProjectPartitionTableEditorTest.java - New test class added
- Comprehensive testing for Partition Table Editor functionality
tests/com.espressif.idf.ui.test/.../EnvSetupOperations.java - Removed C/C++ indexer configuration code
- Added ESP-IDF Manager tab activation/closing
tests/com.espressif.idf.ui.test/.../ProjectTestOperations.java - Reduced project build timeout
- Removed openProjectNewComponentUsingContextMenu method
- Added new methods for shell and partition table testing
tests/pom.xml - Increased JVM memory allocation
- Added new target platform configuration
- Introduced macOS-specific profile

Suggested reviewers

  • alirana01
  • kolipakakondal

Possibly related PRs

  • #1058: Changes in project creation test methods

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3ae0226b3cd6d944a9425609cba33131c404ffa and d394002b07fdddb739c80ccbd6089241f2a27b04.

📒 Files selected for processing (5)
  • tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectPartitionTableEditorTest.java (1 hunks)
  • tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/executable/cases/project/NewEspressifIDFProjectTest.java (2 hunks)
  • tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/operations/EnvSetupOperations.java (1 hunks)
  • tests/com.espressif.idf.ui.test/src/com/espressif/idf/ui/test/operations/ProjectTestOperations.java (5 hunks)
  • tests/pom.xml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jul 01 '24 11:07 coderabbitai[bot]

@alirana01 please review this

kolipakakondal avatar Aug 30 '24 07:08 kolipakakondal

please, review @alirana01 @sigmaaa

Tests cover basic functional checks:

  1. Project not built: Verify if a pop-up appears when opening the Partition Table.
  2. Check if the table content corresponds to the documentation.
  3. Add a row to the table.
  4. Delete a row from the table.
  5. Delete a row, Save and Quit, reopen, and verify the changes.
  6. Delete a row, Save, reopen, and verify the changes.

AndriiFilippov avatar Sep 18 '24 15:09 AndriiFilippov

@AndriiFilippov LGTM can you please verify the builds they are failing on linux

edit:Seems like failures are not your tests

So, could merge ?

AndriiFilippov avatar Sep 20 '24 15:09 AndriiFilippov

@alirana01 @kolipakakondal hi !

builds are fixed on Linux runner.

AndriiFilippov avatar Jan 15 '25 18:01 AndriiFilippov