esp-protocols icon indicating copy to clipboard operation
esp-protocols copied to clipboard

esp_websocket: fix a crash when network anomaly (IDFGH-13461)

Open shootao opened this issue 1 year ago • 2 comments

when disconnect the wifi, the esp_websocket_client_task continue to called esp_transport_poll_read to read, but the default the time is 1s, then the read had timeout will called esp_websocket_client_abort_connection to destory some handle, at this time, esp_websocket_client_send_with_exact_opcode still blocked. when esp_websocket_client_send_with_exact_opcode had timeout, will trigger crash , because handle(erro handle) already release

shootao avatar Aug 14 '24 07:08 shootao

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: shootao
:x: xutao


xutao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 14 '24 07:08 CLAassistant

Thank you for the update! I noticed that there are now two commits from different authors, and the pre-commit test didn’t pass.

Could you please review our contribution guidelines and update this PR accordingly? Specifically, it would be great if you could:

  • Fix the commit messages
  • Squash the two commits into one
  • Rebase the branch (we recently resolved some CI issues on the master branch)

If you’d prefer, just let me know -- I can take care of the chores and push your work in a separate PR, while still crediting your original commit.

david-cermak avatar Aug 21 '24 06:08 david-cermak

@shootao Thanks again for the fixes. will merge by means of https://github.com/espressif/esp-protocols/pull/684

david-cermak avatar Oct 31 '24 07:10 david-cermak