esp-protocols icon indicating copy to clipboard operation
esp-protocols copied to clipboard

Published 20 hours ago • verified publisher icon espressif

feat(esp_modem): example add esp32p4 usb support (IDFGH-12673)

Open leeebo opened this issue 1 year ago • 1 comments

  1. support ec20 cat.4 module in example modem_console and pppos_client
  2. support esp32p4 in example modem_console and pppos_client

Block by https://github.com/espressif/esp-usb/pull/30

leeebo avatar Apr 22 '24 09:04 leeebo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 22 '24 09:04 CLAassistant

Hi @david-cermak Thanks for your review, this MR is blocked by https://github.com/espressif/esp-usb/pull/30, I will finish the test work ASAP.

leeebo avatar May 10 '24 10:05 leeebo

@leeebo this still LGTM,

could we merge it now or wait for the https://github.com/espressif/esp-usb/pull/44 ?

david-cermak avatar Jun 24 '24 08:06 david-cermak

BTW (already told Tomas), the know issue section indicated in

https://github.com/espressif/esp-usb/blob/master/host/class/cdc/esp_modem_usb_dte/CHANGELOG.md?plain=1#L8-L9

could be perhaps solved (worked around) by this option

https://github.com/espressif/esp-protocols/blob/d7eaa77b891a624995c7e641554168bc3383433d/components/esp_modem/Kconfig#L19C12-L28

david-cermak avatar Jun 24 '24 08:06 david-cermak

Hi @david-cermak , it should be ready to merge now. It doesn't need to wait as ^1.2.0 is compatible with 1.2.1

leeebo avatar Jun 24 '24 11:06 leeebo