esp-matter icon indicating copy to clipboard operation
esp-matter copied to clipboard

Typo in total_volatile_organic_compounds_concentration_measurement namespace in esp_matter_attribute.cpp (CON-1133)

Open kibergus opened this issue 9 months ago • 2 comments

The header and other locations use plural compounds in the namespace name. But .cpp has the functions defined in a namespace with a singular compound. As a result attempting to define tvoc sensor leads to undefined symbols during linking.

--- a/components/esp_matter/esp_matter_attribute.cpp
+++ b/components/esp_matter/esp_matter_attribute.cpp
@@ -2754,7 +2754,7 @@ attribute_t *create_level_value(cluster_t *cluster, uint8_t value)
 } /* attribute */
 } /* radon_concentration_measurement */
 
-namespace total_volatile_organic_compound_concentration_measurement {
+namespace total_volatile_organic_compounds_concentration_measurement {
 namespace attribute {
 attribute_t *create_measured_value(cluster_t *cluster, nullable<float> value)
 {
@@ -2823,7 +2823,7 @@ attribute_t *create_level_value(cluster_t *cluster, uint8_t value)
 }
 
 } /* attribute */
-} /* total_volatile_organic_compound_concentration_measurement */
+} /* total_volatile_organic_compounds_concentration_measurement */
 
 namespace operational_state {
 namespace attribute {

kibergus avatar Apr 28 '24 13:04 kibergus

@kibergus Thanks for reporting. If you can, please raise PR with the fix otherwise we will fix it soon.

jadhavrohit924 avatar Apr 29 '24 04:04 jadhavrohit924

Here is a pull request: https://github.com/espressif/esp-matter/pull/918

kibergus avatar May 06 '24 10:05 kibergus

@kibergus Thanks for the PR. We will get it merged soon

dhrishi avatar May 15 '24 05:05 dhrishi

Merged with https://github.com/espressif/esp-matter/commit/c9cae5a87e25363db7db4fc3fe0b2641e0932dc3

dhrishi avatar May 15 '24 05:05 dhrishi