esp-matter icon indicating copy to clipboard operation
esp-matter copied to clipboard

Feature: Change callback in a command (CON-730)

Open Diegorro98 opened this issue 3 years ago • 4 comments

Callback change in a command can be useful in some scenarios where other functionality different from the original is required. Just like the possibility that already exist to override the callback for an attribute.

Diegorro98 avatar Aug 13 '22 08:08 Diegorro98

Out of curiosity, can you give an example where this is helpful?

From my understanding (by looking at the IMClusterCommandHandler.cpp file), for the standard commands, the API which needs to be eventually called was very specific (example emberAfOnOffClusterOnCallback) and this API was implemented in Matter's cluster code.

chiragatal avatar Aug 16 '22 10:08 chiragatal

I am also wondering if a COMMAND_FLAG_OVERRIDE needs to be added, similar to the ATTRIBUTE_FLAG_OVERRIDE, and if that will be useful when calling this callback.

Currently, in esp-matter, for commands with COMMAND_FLAG_CUSTOM, the default response is sent internally based on the return value from the callback.

chiragatal avatar Aug 16 '22 10:08 chiragatal

Out of curiosity, can you give an example where this is helpful?

From my understanding (by looking at the IMClusterCommandHandler.cpp file), for the standard commands, the API which needs to be eventually called was very specific (example emberAfOnOffClusterOnCallback) and this API was implemented in Matter's cluster code.

Sure, it might be helpful when the Matter's cluster code doesn't satisfy the needs or isn't very flexible.

Diegorro98 avatar Aug 16 '22 11:08 Diegorro98

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 22 '22 10:09 CLAassistant