扩充 CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP 的值空间 (AEGHB-1315)
Description
In the esp_ble_conn_ext_advertise method, the adv_params are assigned using CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(0) ~ BIT(7), but now only 0~15 can be set, at most controlling BIT(0) ~ BIT(3), unable to control the higher bits BIT(4) ~ BIT(7). If expanded to BIT(7), it should be 0xFF, which in decimal is 255.
Related
https://github.com/espressif/esp-iot-solution/blob/master/components/bluetooth/ble_conn_mgr/src/esp_nimble.c#L1021
Testing
I just tested it in my project.
Checklist
Before submitting a Pull Request, please ensure the following:
- [x] 🚨 This PR does not introduce breaking changes.
- [ ] All CI checks (GH Actions) pass.
- [ ] Documentation is updated as needed.
- [ ] Tests are updated or added as necessary.
- [ ] Code is well-commented, especially in complex areas.
- [ ] Git history is clean — commits are squashed to the minimum necessary.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
| Warnings | |
|---|---|
| :warning: |
Some issues found for the commit messages in this PR:
Please fix these commit messages - here are some basic tips:
|
👋 Hello wppurking, we appreciate your contribution to this project!
Click to see more instructions ...
This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.
DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.
Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.
Review and merge process you can expect ...
We do welcome contributions in the form of bug reports, feature requests and pull requests.
1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.
Generated by :no_entry_sign: dangerJS against 8f1350e8a9219f8d142c5e2cd400469cfde8d071
I have tried doing the following:
/* extended advertising capability */
adv_params.connectable = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(0));
adv_params.scannable = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(1));
adv_params.directed = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(2));
adv_params.high_duty_directed = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(3));
adv_params.legacy_pdu = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(4));
adv_params.anonymous = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(5));
adv_params.include_tx_power = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(6));
adv_params.scan_req_notif = !!(CONFIG_BLE_CONN_MGR_EXTENDED_ADV_CAP & BIT(7));
But I must have done something wrong with my cap value: 83 (01010011) because I have:
E (15563) blecm_nimble: Configure extended advertising instance error; rc=3