esp-iot-solution icon indicating copy to clipboard operation
esp-iot-solution copied to clipboard

fix(button): Added initialization for gpio_config (AEGHB-1020)

Open victorfleischauer opened this issue 8 months ago • 3 comments

Description

Initializes the gpio_config_t to all zeros, to prevent random value being left in the pull member values of the struct, since they are not set if gpio_cfg->disable_pull is set to true.

Related

Caused this issue.

Testing

I have tested the change by making this line change in the managed_components directory of the example I show in the linked Issue


Checklist

Before submitting a Pull Request, please ensure the following:

  • [ ] 🚨 This PR does not introduce breaking changes.
  • [ ] All CI checks (GH Actions) pass.
  • [ ] Documentation is updated as needed.
  • [ ] Tests are updated or added as necessary.
  • [ ] Code is well-commented, especially in complex areas.
  • [ ] Git history is clean — commits are squashed to the minimum necessary.

victorfleischauer avatar Mar 19 '25 18:03 victorfleischauer

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello victorfleischauer, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by :no_entry_sign: dangerJS against 4aa64fa1674373740867bea26ef8e0d080fdefd0

github-actions[bot] avatar Mar 19 '25 18:03 github-actions[bot]

LGTM! cc @leeebo

lijunru-hub avatar Mar 28 '25 02:03 lijunru-hub

@victorfleischauer Thanks for the bugfix!

leeebo avatar Mar 31 '25 03:03 leeebo