esp-iot-solution icon indicating copy to clipboard operation
esp-iot-solution copied to clipboard

Published 20 hours ago • verified publisher icon espressif

Add Normal State, Fix C++ Compatibilty (AEGHB-337)

Open franz-ms-muc opened this issue 3 years ago • 7 comments

Add Normal State, Fix C++ Compatibilty

franz-ms-muc avatar Aug 03 '22 07:08 franz-ms-muc

@leeebo i updated this to be in sync again with Master.

franz-ms-muc avatar Nov 24 '22 14:11 franz-ms-muc

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '23 06:06 CLAassistant

Hi @franz-ms-muc sorry for the late response, Can you explain more about the application of this changes?

leeebo avatar Aug 08 '23 11:08 leeebo

Due to significant changes in the 'button' component at present, many of the modifications in the pull request are no longer applicable. As a result, this pull request will not be merged. Thank you very much for your contribution.

lijunru-hub avatar Aug 09 '23 06:08 lijunru-hub

Hi @franz-ms-muc sorry for the late response, Can you explain more about the application of this changes?

Hi @leeebo i will close this one, and submit new, with splitted into several PRs to get clearer overview.

franz-ms-muc avatar Jan 18 '24 12:01 franz-ms-muc

First one here: #327

franz-ms-muc avatar Jan 18 '24 12:01 franz-ms-muc

the second one was already fixed by putting "usr_data" into a struct:

see: https://github.com/espressif/esp-iot-solution/blob/996917bc7674f2392d676539809e14951694055c/components/button/iot_button.c#L36C1-L40C20

franz-ms-muc avatar Jan 18 '24 12:01 franz-ms-muc