esp-idf icon indicating copy to clipboard operation
esp-idf copied to clipboard

fix(freertos): Avoid core switch deadlock on start (IDFGH-15509)

Open gonzzor opened this issue 7 months ago • 2 comments

Description

With CONFIG_ESP_MAIN_TASK_AFFINITY_NO_AFFINITY=y the main task could switch core between registering the idle hook and the while loop.

This would cause a deadlock were the current task was waiting for the idle hook to run on the same core it's busy waiting.

Solve this by registering an idle hook on both cores. This ensure that the scheduler is started on the other core.

Related

Testing

This problem was discovered on an ESP32-S3 running 5.4.1 with QIO and CONFIG_ESP_MAIN_TASK_AFFINITY_NO_AFFINITY=y. It would randomly happen during boot.

With this change the problem hasn't been possible to reproduce.


Checklist

Before submitting a Pull Request, please ensure the following:

  • [x] 🚨 This PR does not introduce breaking changes.
  • [ ] All CI checks (GH Actions) pass.
  • [ ] Documentation is updated as needed.
  • [ ] Tests are updated or added as necessary.
  • [ ] Code is well-commented, especially in complex areas.
  • [x] Git history is clean — commits are squashed to the minimum necessary.

gonzzor avatar Jun 17 '25 09:06 gonzzor

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello gonzzor, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against b97d674836a2c593e118907ca4f5e7b17fb30d3d

github-actions[bot] avatar Jun 17 '25 09:06 github-actions[bot]

I will test this case. I wonder if this is the proper way to fix the issue.

Thanks, let me know if you need more input from me.

gonzzor avatar Jun 17 '25 15:06 gonzzor

I was able to reproduce this behavior in a test; it can occur. I will add this PR to our internal repository. The final solution may differ slightly from your original commit. Thanks.

KonstantinKondrashov avatar Jun 26 '25 13:06 KonstantinKondrashov

sha=b97d674836a2c593e118907ca4f5e7b17fb30d3d

KonstantinKondrashov avatar Jun 26 '25 13:06 KonstantinKondrashov