esp-idf icon indicating copy to clipboard operation
esp-idf copied to clipboard

feat(fatfs): add Kconfig settings for FF_USE_STRFUNC (IDFGH-12317)

Open KJ7LNW opened this issue 11 months ago • 5 comments

Legacy fatfs code being ported to ESP-IDF may use f_gets(), f_puts(), f_putc(), and f_printf() calls, but the define FF_USE_STRFUNC is set to 0 without Kconfig options to enable it.

This commit retains the existing default behavior of FF_USE_STRFUNC=0 and adds Kconfig settings so users can configure FF_USE_STRFUNC and the related FF_PRINT_LLI, FF_PRINT_FLOAT, and FF_STRF_ENCODE if needed.

Closes: https://github.com/espressif/esp-idf/issues/13350

(This PR replaces #13351 which had an invalid branch name due to capital letters.)

KJ7LNW avatar Mar 11 '24 00:03 KJ7LNW

Messages
:book: 🎉 Good Job! All checks are passing!

👋 Hello KJ7LNW, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by :no_entry_sign: dangerJS against 1ad06064d116d6556839a4b6870730e5fe79e1ef

github-actions[bot] avatar Mar 11 '24 00:03 github-actions[bot]

Thanks for contribution.

Alvin1Zhang avatar Mar 11 '24 00:03 Alvin1Zhang

Hi, thank you for contributing!

haberturdeur avatar Mar 20 '24 10:03 haberturdeur

@haberturdeur, updated and force pushed. Please double-check that this is what you needed.

KJ7LNW avatar Apr 08 '24 21:04 KJ7LNW

LGTM!

haberturdeur avatar Apr 09 '24 11:04 haberturdeur