esp-bsp
esp-bsp copied to clipboard
bsp: Update BSPs for using button v4
ESP-BSP Pull Request checklist
- [x] Version of modified component bumped
- [x] CI passing
Change description
- Updated BSPs for using it with button component v4
Updated BSPs to button v4
- [x] esp_bsp_devkit (done in another PR)
- [x] esp_bsp_generic (done in another PR)
- [x] esp_wrover_kit
- [x] esp32_azure_iot_kit
- [x] esp32_c3_lcdkit
- [x] esp32_lyrat
- [x] esp32_p4_function_ev_board (no buttons)
- [x] esp32_s2_kaluga_kit - NOT TESTED ON HW
- [x] esp32_s3_eye
- [x] esp32_s3_korvo_1 - NOT TESTED ON HW
- [x] esp32_s3_korvo_2
- [x] esp32_s3_lcd_ev_board
- [x] esp32_s3_usb_otg
- [x] esp-box-3
- [x] m5dial
- [x] m5stack_core
- [x] m5stack_core_2 (no buttons)
- [x] m5stack_core_s3 (no buttons)
No SD card = RELEASE
- esp32_c3_lcdkit
- esp32_s2_kaluga_kit
- esp32_s3_lcd_ev_board
- m5dial
Test Results
19 files 19 suites 6m 18s ⏱️ 76 tests 26 ✅ 50 💤 0 ❌ 494 runs 26 ✅ 468 💤 0 ❌
Results for commit 43d1158b.
:recycle: This comment has been updated with latest results.
@tore-espressif PTAL
However, looking at the button v4 changes, there are only 2:
I am not sure, if there are real breaking changes:
- When you are using button v3 with LVGL port --> No breaking changes
- When you change from v3 to v4 button with LVGL port --> You must make changes
- In BSPs, there is everything handled inside or in examples --> No breaking changes
And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs)
And when I am thinking about it, there can be solution for use both version of button in BSPs too. I am not suer, if we want it (add more ifdefs)
I'd prefer supporting only one (the latest) version
I'd prefer supporting only one (the latest) version
OK, should I increase major version of affected BSPs?
Sorry for the late reply. The custom button can be created using the factory mode of the new button component. You can refer to this file:
[custom_button_test.c](https://github.com/espressif/esp-iot-solution/blob/master/components/button/test_apps/main/custom_button_test.c)
Sorry for the late reply. The custom button can be created using the factory mode of the new button component. You can refer to this file:
[custom_button_test.c](https://github.com/espressif/esp-iot-solution/blob/master/components/button/test_apps/main/custom_button_test.c)
@lijunru-hub Thank you!
@tore-espressif I updated this PR with changes for all BSPs with button v4. PTAL
LGTM!