esp-bsp icon indicating copy to clipboard operation
esp-bsp copied to clipboard

Published 20 hours ago • verified publisher icon espressif

feat(LVGL port): Support for RGB screen

Open espzav opened this issue 10 months ago • 2 comments

ESP-BSP Pull Request checklist

  • [ ] Waiting for merge #320
  • [x] Version of modified component bumped
  • [ ] CI passing

Change description

1: esp_lv_port adds RGB interface support

All BSPs will be updated in next PR.

Many thanks to @espressif2022 for very well support! This PR is made from #313

espzav avatar Apr 25 '24 10:04 espzav

One issue is here. When I am using display (https://github.com/espressif/esp-bsp/tree/master/examples/display) example with SPI/DSI display, it is not working properly with this line: https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L230 and this line https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L216 I am working on it. I don't know, how to handle right, for maximum task sleep.

espzav avatar Apr 26 '24 13:04 espzav

@tore-espressif PTAL

espzav avatar Apr 26 '24 14:04 espzav

One issue is here. When I am using display (https://github.com/espressif/esp-bsp/tree/master/examples/display) example with SPI/DSI display, it is not working properly with this line:

https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L230

and this line https://github.com/espressif/esp-bsp/blob/81a36703ea8743553788c5e8a718642738a07de9/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c#L216

I am working on it. I don't know, how to handle right, for maximum task sleep.

Fixed on master.

espzav avatar May 14 '24 07:05 espzav

@espressif2022 and @tore-espressif Do we want to update BSP for esp32_s3_lcd_ev_board in this PR or should we make new PR (or update #313)?

espzav avatar May 14 '24 07:05 espzav

@espressif2022 and @tore-espressif Do we want to update BSP for esp32_s3_lcd_ev_board in this PR or should we make new PR (or update #313)?

There is an RGB example in the test case. I think this PR does not need to be updated BSP of esp32_s3_lcd_ev_board.

espressif2022 avatar May 15 '24 03:05 espressif2022

@tore-espressif Thank you for the first round of the review. I fixed all issues. You can continue.

espzav avatar May 20 '24 13:05 espzav