esp-adf-libs icon indicating copy to clipboard operation
esp-adf-libs copied to clipboard

esp-adf-libs includes a hidden copy of libopus

Open hossbeast opened this issue 2 years ago • 1 comments

I've noticed that esp-adf-libs includes a bundled copy of libopus, from https://github.com/xiph/opus. I described my findings here - https://github.com/XasWorks/esp-libopus/issues/3

My request is that esp-adf-libs 1) make it clear that libopus is included with esp-adf-libs, including precise version information, and 2) vend the libopus header files from whatever version it was built from.

Opus is great, and folks have a need for it to be built for esp32. Make it obvious that it's there and make it easy to use - that can only help the users of esp-adf-libs.

hossbeast avatar Aug 30 '22 03:08 hossbeast

@hossbeast The copyrights notice on https://docs.espressif.com/projects/esp-adf/en/latest/COPYRIGHT.html. The version of opus is v1.2.1, which will be update on esp-adf-libs.

jason-mao avatar Sep 02 '22 01:09 jason-mao