arduino-esp32 icon indicating copy to clipboard operation
arduino-esp32 copied to clipboard

Added NVS test sketch + test script

Open P-R-O-C-H-Y opened this issue 3 years ago • 11 comments

Description of Change

Added simple NVS test.

Related links

#6884

P-R-O-C-H-Y avatar Jun 20 '22 07:06 P-R-O-C-H-Y

Unit Test Results

17 files  17 suites   3m 15s :stopwatch:   8 tests   8 :heavy_check_mark: 0 :zzz: 0 :x: 22 runs  22 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit f8888ab1.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 24 '22 11:06 github-actions[bot]

@P-R-O-C-H-Y flash modes are working now in the 4.4 branch. You can test against that and master if you want to verify that it fails on one, but not the other. cc: @Ouss4

me-no-dev avatar Jun 25 '22 13:06 me-no-dev

@me-no-dev Can confirm that on C3 and S3 all modes are again working on idf-release/v4.4 branch. Great job!

P-R-O-C-H-Y avatar Jun 27 '22 09:06 P-R-O-C-H-Y

FQBN Additions:

  • ESP32-S3: FlashMode=[qio|qio120|dio|opi]
  • Rest: FlashMode=[qio|qout|dio|dout],FlashFreq=[40|80]

me-no-dev avatar Jun 27 '22 11:06 me-no-dev

There is a problem with the test @P-R-O-C-H-Y . Since the value is in NVS, it is probably already set to something from previous run and will never again start from 0, so what the test expects will fail (as it did). Maybe you need to rethink the test or find a way to erase flash prior to running the test.

me-no-dev avatar Jun 27 '22 11:06 me-no-dev

We are waiting for @Ouss4 to make a PR with a few CI changes. One will be the flash erase so the test will work after that PR ;)

P-R-O-C-H-Y avatar Jun 27 '22 11:06 P-R-O-C-H-Y

Not to derail this pr, but is there actually eqpt out there that will only run on dout/qout?

lbernstone avatar Jun 27 '22 20:06 lbernstone

Not to derail this pr, but is there actually eqpt out there that will only run on dout/qout?

yes. I have a board that has flash which can do only dout. It's very rare, but exists and also can free up some IO if you do not need the throughput.

me-no-dev avatar Jun 27 '22 22:06 me-no-dev

Not to derail this pr, but is there actually eqpt out there that will only run on dout/qout?

yes. I have a board that has flash which can do only dout. It's very rare, but exists and also can free up some IO if you do not need the throughput.

Ok, just asking. I have some cheap sh!t in my bin, and I've never seen it :smile:

lbernstone avatar Jun 27 '22 22:06 lbernstone

Status update: Blocked by missing HW on our runners.

VojtechBartoska avatar Jul 20 '22 12:07 VojtechBartoska

Status update: Hw will be installed tomorrow morning.

P-R-O-C-H-Y avatar Aug 10 '22 10:08 P-R-O-C-H-Y

To-Do:

  • Write down internal Wiki page about "How to release"

VojtechBartoska avatar Aug 15 '22 12:08 VojtechBartoska