Emanuele Giuseppe Esposito
Emanuele Giuseppe Esposito
Probably I'll need to remove the volatile-usr unit too, we can do a single binary and a single unit. Will update it on Monday
@keszybz tested, should be ready to be reviewed
@keszybz can you review?
@lmilleri @fitzthum FYI
Thanks for the review! > * should we call the toggle and variable/field in the code `admin_api_read_only`? `ro` is not very grepable, and it's unidiomatic in rust to sacrifice characters...
> AFAIU, auth_public_key=Some(...) would be overridden by read_only=true. Can we change the internal representation (not the user toggles) of AdminConfig to reflect that by using an auth enum: Actually, no...
I pushed a new version applying almost all changes except - `admin_api` prefix is still there - no enum as I explained in the previous comment, I don't think it...
The question is... do we need the kbs to be able to still fetch (GET) stuff from the trustee? What would be the use case? Otherwise I can simply block...
ok so let's leave it as it is, let me apply the HEAD and formatting fixes and we should be done
> The main area of concern is that setting reference values via the operator circumvents the extractors built into the RVPS. Technically this PR doesn't really affect that because when...