espidev
Renting improvements!
I am copy-pasting this straight from my server's Discord staff chat. I have a very kind mod that tested the renting functionality very carefully 😄
Okay here are the issues: • The landlord can stop the lease whenever they want, with no warnings to the tenant. This is an issue because they could just rent it out to someone and then evict them, taking their emeralds. In addition, any blocks that the tenant placed whilst renting the claim are now inaccessible to them so the landlord has basically stolen them too. • If the lease is stopped by the landlord the renter doesn’t get a refund or anything. • The lease is automatically renewed when it runs out with no warning to the landlord or the tenant. This is an issue because the landlord or tenant may only wish to rent it for one term, but if they’re offline when it renews there’s nothing they can do to stop it. Even if they’re online it may take them by surprise as there’s no warning. • There’s no way to tell how long the lease is for/how long there is remaining on the lease once it’s been rented. /ps info tells you who the landlord is, who the “seller” (i.e. tenant) is, and what the rent price is, but not how long it’s for. • If someone rents a claim from you whilst you’re offline, it doesn’t tell you. Someone could be renting from you and you’d be completely unaware.
Some things that would improve it: • More notifications! If your lease is coming to an end, if someone rents from you whilst you’re offline, if the landlord evicts you, etc. • A notification when you enter the claim e.g. “this claim is available to rent” • A command like /ps list that tells you all the claims you’re renting from/renting to people, how long they have left, and what the price is • /autorent to toggle autorenewal on the lease • A way to rename claims. It’s very difficult to identify which claim is which when they’re all named something like ps-1986x69y1700z
"A way to rename claims"... we discussed that in the past, didn't we? :) From what i remember you said it wasn't possible. But i checked again and saw a /ps name command. Isn't it for renaming regions?
I am copy-pasting this straight from my server's Discord staff chat. I have a very kind mod that tested the renting functionality very carefully
Feel free to also join the M.O.S.S. discord server!
Okay here are the issues: • The landlord can stop the lease whenever they want, with no warnings to the tenant. This is an issue because they could just rent it out to someone and then evict them, taking their emeralds. In addition, any blocks that the tenant placed whilst renting the claim are now inaccessible to them so the landlord has basically stolen them too. • If the lease is stopped by the landlord the renter doesn’t get a refund or anything.
So the refund one should be fixed, but I am not so sure about how lease stops would work then.
• The lease is automatically renewed when it runs out with no warning to the landlord or the tenant. This is an issue because the landlord or tenant may only wish to rent it for one term, but if they’re offline when it renews there’s nothing they can do to stop it. Even if they’re online it may take them by surprise as there’s no warning. • There’s no way to tell how long the lease is for/how long there is remaining on the lease once it’s been rented. /ps info tells you who the landlord is, who the “seller” (i.e. tenant) is, and what the rent price is, but not how long it’s for.
True. Options should probably be added on the tenant side for how many terms the rent will go on for. /ps info is going to be undergoing revamp with a page on rents: #150
• If someone rents a claim from you whilst you’re offline, it doesn’t tell you. Someone could be renting from you and you’d be completely unaware.
Not sure how I would address that, since I have to create a system for saving events
Some things that would improve it: • More notifications! If your lease is coming to an end, if someone rents from you whilst you’re offline, if the landlord evicts you, etc. • A notification when you enter the claim e.g. “this claim is available to rent” • A command like /ps list that tells you all the claims you’re renting from/renting to people, how long they have left, and what the price is
In 2.7.0 landlord eviction messages were added. /ps list is planned to be overhauled a bit with separate pages for rents. /ps rent list would probably be a good idea.
• /autorent to toggle autorenewal on the lease
Yeah some system to set rent settings would need to be made.
• A way to rename claims. It’s very difficult to identify which claim is which when they’re all named something like ps-1986x69y1700z
"A way to rename claims"... we discussed that in the past, didn't we? :) From what i remember you said it wasn't possible. But i checked again and saw a /ps name command. Isn't it for renaming regions?
/ps name is for adding an alias on top of regions, which is basically what you want I think? It does not actually rename the region itself (in WorldGuard)
Overall I am pretty overwhelmed with features to add after doing taxes... Almost a third of the plugin's code base already has to do with taxes and rents so it has been challenging to move around code without breaking random features such as merging and so on.
Some of the features here will be in v2.8.0, such as a revamped /ps info and /ps rent list. Others may take a long time, such as add a settings system for rents because that has to be abstracted on top of flag storage in worldguard...
